[IMP] awesomeclicker: add editor metadata in Python file by jupao-odoo · Pull Request #1173 · odoo/tutorials

jupao-odoo · 2026-02-16T13:30:23Z

Added a new line 'editor': "jupao" in the module code to indicate the editor used for this script. This helps with code clarity and consistency within the module.

robodoo · 2026-02-16T13:30:26Z

- Initialize module structure - Create estate.property model - Add basic fields and attributes - Add security access rules - Add action and menus for UI

Add custom views for the `estate.property` model to improve user interface and data interaction. The commit introduces: - A list view showing key fields: name, postcode, bedrooms, living area, expected price, selling price, and available date. - A form view with structured groups and a notebook for detailed information including description, property features, and reserved fields like active and state. - A search view with filters and group-by options to easily find and categorize properties, including an "Available" filter for new and offer_received properties, and a group-by on postcode. This improves the usability of the real estate module, replacing default auto-generated views with tailored ones that match business requirements. Closes task-6

ltinel

Great work :)

FYI, if you scroll to the bottom of your PR, you'll find some Runbot links, among which the ci/style check. In there, you'll find a few styling suggestions (typically incorrect use of whitespace or newlines). Could you implement those to make the check pass?

ltinel · 2026-02-17T12:46:03Z

awesome_clicker/__manifest__.py

    """,

    'author': "Odoo",
+    'editor': "jupao",


No need for this change :) I guess it was just a test?

ltinel · 2026-02-17T12:50:05Z

estate/models/estate_property.py

+
+    available_from = fields.Date(
+        copy=False,
+        default=lambda self: fields.Date.today() + timedelta(days=90)


We usually work with relativedelta (from dateutil.relativedelta import relativedelta):

Suggested change

default=lambda self: fields.Date.today() + timedelta(days=90)

default=lambda self: fields.Date.today() + relativedelta(months=3)

ltinel · 2026-02-17T13:03:55Z

estate/views/estate_property_views.xml

+        <field name="arch" type="xml">
+            <search string="Property">
+
+                <field name="name" string="Title"/>


Instead of overriding the string here (which is fine, by the way), you could also set it directly in the model (in the py file).

ltinel · 2026-02-17T13:05:02Z

estate/__manifest__.py

+    'summary': """
+        Starting module for "Master the Odoo web framework, chapter 1: Build a new application"
+    """,
+
+    'description': """
+        Starting module for "Master the Odoo web framework, chapter 1: Build a new application"
+    """,


These don't seem quite right :)

ltinel · 2026-02-17T13:05:20Z

estate/views/estate_menus.xml

+    <!-- Root Menu -->
+    <menuitem 
+        id="estate_menu_root" 
+        name="Real Estate"/>
+
+    <!-- First Level -->
+    <menuitem 
+        id="estate_menu_properties"
+        name="Properties"
+        parent="estate_menu_root"/>
+
+    <!-- Action Menu -->
+    <menuitem 
+        id="estate_menu_properties_action"
+        parent="estate_menu_properties"
+        action="estate_property_action"/>


If you nest the menu items, you won't need to explicitly specify a parent anymore.

ltinel · 2026-02-17T13:06:22Z

estate/__manifest__.py

+    'category': 'Tutorials',
+    'version': '0.1',
+    'application': True,
+    'installable': True,


FYI, I believe this is the default, so you don't strictly need to specify it.

ltinel · 2026-02-17T13:06:37Z

estate/__manifest__.py

+        Starting module for "Master the Odoo web framework, chapter 1: Build a new application"
+    """,
+
+    'author': "Odoo",


In general, we put Odoo S.A. here, but it doesn't matter much in this context 😄

ltinel · 2026-02-17T13:07:02Z

estate/__manifest__.py

+        'views/estate_menus.xml'
+    ],
+
+    'assets': {},


Feel free to remove this since it's empty.

ltinel · 2026-02-17T13:11:40Z

settings.json

This is your own config file, so it should probably stay local :) Maybe add it to your gitignore file to avoid including it in your PRs.

Introduce estate.property.type and estate.property.tag models. Extend estate.property with: - Many2one relation to property type - Many2many relation to property tags - One2many relation to property offers Add corresponding views and menus where required. Fix flake8 issues to satisfy ci/style checks.

@onchange

- estate.property: * added total_area computed field (living_area + garden_area) * added best_price computed field (maximum of offer prices) * added @onchange on 'garden' to set default garden_area=10 and garden_orientation='north' - estate.property.offer: * added validity_date computed field (with inverse)

Chapter 9: link business logic to UI actions - estate.property: * Add "Cancel" and "Sold" buttons in form view header. * Enforce state constraints: a cancelled property cannot be sold and a sold property cannot be cancelled. * Raise UserError when state transitions are invalid. - estate.property.offer: * Add "Accept" and "Refuse" buttons. * Accepting an offer sets the buyer and selling price on the related property. * Only one offer can be accepted per property. - Updated views to include buttons in header sections. - Added Python methods implementing the business logic for these actions.

ltinel

Good job :)

ltinel · 2026-02-17T16:12:30Z

estate/models/estate_property_offer.py

+        'estate.property',
+        string="Property",
+        required=True,
+        ondelete='cascade'


Good idea :) Although maybe not ideal in practice for tracking offers.

ltinel · 2026-02-17T16:15:45Z

estate/views/estate_menus.xml

+    <menuitem 
+        id="estate_menu_type"
+        name="Property Type"
+        parent="estate_menu_root"/>


I believe this menu item (and the "Property Tags" one) should be under a "Settings" menu item. But all of this would be simpler if you use nesting instead of the "parent" field :)

ltinel · 2026-02-17T16:16:31Z

estate/views/estate_menus.xml

+    <!-- Property Type Action -->
+    <record id="estate_property_type_action" model="ir.actions.act_window">
+        <field name="name">Property Type</field>
+        <field name="res_model">estate.property.type</field>
+        <field name="view_mode">list,form</field>
+    </record>


Actions should be in the "_views" file of the corresponding record. (same below)

ltinel · 2026-02-17T16:18:53Z

estate/views/estate_property_views.xml

-                <field name="expected_price"/>
-                <field name="selling_price"/>
-                <field name="available_from"/>
+                <field name="name" width="100px"/>


It's fine to set a width, but hardcoding pixels can be risky, since users can have different screen sizes (monitor, laptop, smartphone, ...)

ltinel · 2026-02-17T16:19:24Z

estate/views/estate_property_views.xml


                    <group>
                        <group>
+                            <field name="tag_ids" widget="many2many_tags"/>


Could you move this in the oe_title div?

ltinel · 2026-02-17T16:20:19Z

estate/views/estate_property_views.xml

+                                <list editable="bottom">
+                                    <field name="price"/>
+                                    <field name="partner_id"/>
+                                    <field name="status"/>
+                                </list>


No need for this :) You can put the editable="bottom" attribute directly in the list view of the offer (in estate/views/estate_property_offer_views.xml)

Suggested change

<list editable="bottom">

<field name="price"/>

<field name="partner_id"/>

<field name="status"/>

</list>

[IMP] awesomeclicker: add editor metadata in Python file

9a8f241

Added a new line 'editor': "jupao" in the module code to indicate the editor used for this script. This helps with code clarity and consistency within the module.

ltinel self-requested a review February 16, 2026 16:14

jupao-odoo added 2 commits February 16, 2026 17:28

feat(estate): complete tutorial chapters 1-5

67c3350

- Initialize module structure - Create estate.property model - Add basic fields and attributes - Add security access rules - Add action and menus for UI

ltinel reviewed Feb 17, 2026

View reviewed changes

jupao-odoo added 3 commits February 17, 2026 15:08

ltinel reviewed Feb 17, 2026

View reviewed changes

	default=lambda self: fields.Date.today() + timedelta(days=90)
	default=lambda self: fields.Date.today() + relativedelta(months=3)

Conversation

jupao-odoo commented Feb 16, 2026

Uh oh!

robodoo commented Feb 16, 2026

Uh oh!

ltinel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ltinel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants